Skip to content

fix(auth): honor request timeout during configure#52

Open
JerryNee wants to merge 1 commit into
TestSprite:mainfrom
JerryNee:fix/configure-request-timeout
Open

fix(auth): honor request timeout during configure#52
JerryNee wants to merge 1 commit into
TestSprite:mainfrom
JerryNee:fix/configure-request-timeout

Conversation

@JerryNee

@JerryNee JerryNee commented Jun 28, 2026

Copy link
Copy Markdown

Summary

  • pass requestTimeoutMs into the pre-write /me validation client used by auth configure / setup
  • ensure a configured short request timeout also bounds the key-validation ping before credentials are written
  • add regression coverage that proves the validation fetch receives an abort signal and credentials are not persisted on timeout

Why

runConfigure builds a one-off HttpClient so it can validate the candidate key before writing credentials. That path bypassed makeHttpClient, so the global --request-timeout value was parsed but not applied to the validation ping.

Verification

  • npm test -- src/commands/auth.test.ts
  • npm run lint
  • npm run typecheck
  • npm test
  • npm run build

@zeshi-du

zeshi-du commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zeshi-du, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 554f137e-4735-4b4a-a6ae-58631174a141

📥 Commits

Reviewing files that changed from the base of the PR and between 15e95de and 976045d.

📒 Files selected for processing (2)
  • src/commands/auth.test.ts
  • src/commands/auth.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JerryNee @zeshi-du